Implement the recent addition of the tone/effects library for the rp355.
Get rid of USB_POSITION.
Add tone lib A for rp355.
Minor comment changes.
Remove a couple of commented out lines.
Conflicts:
.gitignore
effects.c
gdigi.c
gdigi.h
gdigi_xml.h
gui.c
gui.h
preset.c
preset_xml.c
effects.c: More effect_values_0_to_* arrays for various effects.
VALUE_TYPE_POSID for linkable effects.
Add the rest of the global settings (need to change USB_POSITION
to GLOBAL_POSITION throughout).
A few label typos.
New settings, groups, and effects for linkables.
Make the display three rows instead of two.
Add missing modifiers.
Add missing xml settings.
Code for handling/updating the global modifier linkable list.
effects.h Add VALUE_TYPE_POSID.
gdigi.c Tweaks for value formatting.
Use NOTIFY_MODIFIER_GROUP_CHANGED to drive the update of the combo
boxes for linkable effects.
Use RECEIVE_MODIFIER_LINKABLE_LIST to handle the update of the
combo boxes for linkable effects.
gdigi.h Minor changes.
gui.c Deprecate gtk_vbox_new().
Use simpler API gtk_combo_box_text_append_text().
Minor reformatting/whitespace changes.
Code to update combo boxes for linkable effects.
Code to retrieve global parameters from device at startup.
preset_xml.c
Some tweaks to map_xml_value() so that it's passed resolved
EffectValues for settings of type EXTRA.
RP255 (firmware version 1.1) has the Tone Library at position 25, instead of 26.
Add this library position alternative as "LIB_POSITION_B", renaming the existing
one to LIB_POSITION_A, and add the corresponding bits at effects.c.
Also, adds a menu there, to let it to be controlled via the library.
1) Add a more reasonable max value for the the pedal/vswitch assign values.
2) Minor format change in format_ipv().
3) Formatting cleanup in push_message(). Also change debug messages to
emphasize message direction.
4) Cleanup startup messages and add one that emits device name.
5) Cleanup the option message so that it's complete and readable.
Leverage the code that writes a preset to XML so that messages
can be displayed in a human readable format.
E.g.,
(6, 2432, 1280) Distortion: Dist Type: Screamer
The 3-tuple is position, id, value, which is followed by the
colon separated decode of the position, id, and the mapped value.
Leverage the code that writes a preset to XML so that messages
can be displayed in a human readable format.
E.g.,
(6, 2432, 1280) Distortion: Dist Type: Screamer
The 3-tuple is position, id, value, which is followed by the
colon separated decode of the position, id, and the mapped value.
Change AMP_POSITION to AMP_A_POSITION.
Add AMP_B_POSITION to the modifier array.
Add AMP_PRESENCE to the modifier array and move it to follow Treble
in the Equalizer effect.
Add EQ_B_POSITION settings to the modifier array.
Change the formatting of the debug messages to print more
readable columns.
Conflicts:
gdigi.c
1) Make logging conditional on debug flags.
2) Add command line option for setting these flags.
3) Emit warnings with g_warning() instead of g_message().
4) Added note about how FX_LIB_LEVEL_MAX[1-3] is used.
Change AMP_POSITION to AMP_A_POSITION.
Add AMP_B_POSITION to the modifier array.
Add AMP_PRESENCE to the modifier array and move it to follow Treble
in the Equalizer effect.
Add EQ_B_POSITION settings to the modifier array.
Change the formatting of the debug messages to print more
readable columns.
2) In effects.c, some EffectsValues are changed to better reflect the
strings used in the XML.
3) New EffectSettings are added for use when writing out effects to XML.
4) Added an XmlLabel structure for mapping a value to a string. Generally,
these are the union of the set of all values over the set of supported
devices.
5) There's a large array of XmlSettings used to derive the translation of
a preset to XML.
6) Add an enum for product_id and use it to set a filter for file suffix.
7) Minor cleanup in push_message() that suppresses spurious error messages.
8) Fixed a bad memset in read_data_thread().
9) In gdigi.h, a few changes in names to be consistent with XML.
There are some new definitions of LFO and VSWITCH parameters that
need to be computed.
10) In gui.c, fixed up a compiler warning.
Added a map from device id to file type and code to set a default filter
in the read dialog.
Wired up the 'save to XML' callback and reorganized the menue entries to
better distinguish between 'save to file' and 'store to device'.
In preset.c, sort the params so that what we write as XML more closely
matches what is generated on the windows side.
