These changes allow gdigi to link parameters to the expression pedal,
LFO1, and LFO2. The changes have been implemented only for RP355, but
should be easily extendible to other devices.
The design is as follows:
The effect group entries for the linkable effects have only a placeholder
entry "None" at startup.
During startup, we send an unsolicited REQUEST_MODIFIER_LINKABLE_LIST. When we
receive RECEIVE_MODIFIER_LINKABLE_LIST in response, we use it to construct the
ModifierLinkableList and update the combo boxes for the Pedal Assign and LFO
effects.
Whenever the selected chorus/fx effect changes, the list of linkable parameters
also changes, so the device will send us a NOTIFY_MODIFIER_GROUP_CHANGED. Again,
we send a REQUEST_MODIFIER_LINKABLE_LIST and use the response to rebuild
ModifierLinkableList. Then we tear down and rebuild the state associated with
the affected combo boxes.
The changes made are as follows:
1) Add settings for pedal1_assign. This is the min/max value returned
by the pedal.
2) Add separate EffectGroup for both pedal assignment and the LFO's
for the non-combo box settings.
3) Fix up a few more missing effects in the xml and modifier lists.
There is additional work to do here, but that will be in future
commits.
4) Fixed a missing break in the RECEIVE_DEVICE_NOTIFICATION case
in push_message().
5) When we receive a NOTIFY_MODIFIER_GROUP_CHANGED message, free the exisiting
modifier group and send a REQUEST_MODIFIER_LINKABLE_LIST so we can
rebuild it.
6) When we receive a RECEIVE_MODIFIER_LINKABLE_LIST, protect the calls to
create_modifier_group() with GDK_THREADS_ENTER() so we don't crash
because of interactions with the event/gui threads.
7) Added a BUG assert to an error leg in get_message_list().
8) Fix memory leak in get_digitech_devices() found by valgrind.
9) Add a function to tear down the state associated with the entries of a
pedal assign or LFO combo box.
10) Add a function to build up the entries of a pedal assign or LFO combo
box from the modifier linkable list received from the device.
11) Use gtk_combo_box_text_append_text() throughout.
12) A few whitespace/readability changes and more comments.
The API's gtk_vbox_new() and gtk_hbox_new() are deprecated and result
in compilation warnings. Replace these API's with calls to
gtk_box_new() with GTK_ORIENTATION_VERTICAL and GTK_ORIENTATION_HORIZONTAL,
respectively.
For now, this is just for rp355, though the code should work for other
devices with minimal modification.
1) The EffectValues for values_*_assign need to be VALUE_TYPE_POSID.
2) Disabmiguate "Delay Tape" for a couple of EffectSettings. This fixed
some bugs in the creation of the global modifier group.
3) Remove #if 0's around the definition of the lfo2_settings.
4) Define proper lfo1 and lfo2 groups arrays.
5) Define the lfo2_effect[] array.
6) Add the lfo1 and lfo2 effects to the rp355_effects array.
7) Disambiguate "EQ B" from "Eq" for some effedts in the modifiers array.
8) In push_message(), after we receive the RECEIVE_MODIFIER_LINKABLE_LIST
message, kick off the creation of the EXP, LFO1, and LFO2 effects.
9) Generalize the function used for the pedal1_assign effect and make it work
for lfo1 and lfo2 as well. Convert printf's to debug_msg().
10) Since we're destroying the association of the grid with the placeholder
combo box entry, steal the data so the child widget isn't destroyed.
11) Silence warning on exit about 0 unread messages in queue.
1) Make logging conditional on debug flags.
2) Add command line option for setting these flags.
3) Emit warnings with g_warning() instead of g_message().
4) Added note about how FX_LIB_LEVEL_MAX[1-3] is used.
2) In effects.c, some EffectsValues are changed to better reflect the
strings used in the XML.
3) New EffectSettings are added for use when writing out effects to XML.
4) Added an XmlLabel structure for mapping a value to a string. Generally,
these are the union of the set of all values over the set of supported
devices.
5) There's a large array of XmlSettings used to derive the translation of
a preset to XML.
6) Add an enum for product_id and use it to set a filter for file suffix.
7) Minor cleanup in push_message() that suppresses spurious error messages.
8) Fixed a bad memset in read_data_thread().
9) In gdigi.h, a few changes in names to be consistent with XML.
There are some new definitions of LFO and VSWITCH parameters that
need to be computed.
10) In gui.c, fixed up a compiler warning.
Added a map from device id to file type and code to set a default filter
in the read dialog.
Wired up the 'save to XML' callback and reorganized the menue entries to
better distinguish between 'save to file' and 'store to device'.
In preset.c, sort the params so that what we write as XML more closely
matches what is generated on the windows side.
